Replace Subgraph urls with new ones sourced from docs #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taken from: https://docs.toucan.earth/developers/sdk/subgraph. Also, removed obsolete mumbai subgraph.
Closed
|
Marking this as draft for the time being as there are a few things still to be ironed out. |
We want everybody to use their own API keys for Subgraph queries. However, we need an API key to run our Subgraph regression tests against live endpoints on pull requests. That's why a tightly scoped key is added to our CI workflow config. IMPORTANT: That means if you extend the regression tests to also query other networks than Alfajores, you need to make sure the API key has permissions for those networks.
Sushiswap and Ubeswap migrated to the decentralized network and also their API changed. This needs to be a slightly bigger rework that will be tracked in LILA-7487. This is a problem because the CI is breaking because of it.
Without this patch the matic playground URL was still pointing to the discontinued Hosted Service. I used the opportunity to also add links to all other playgrounds.
pheuberger
force-pushed
the
update-subgraph-urls
branch
from
4d17614 to
3963b5e
Compare
0xmichalis
reviewed
Jul 8, 2024
0xmichalis
previously approved these changes
Jul 8, 2024
|
@pheuberger maybe you want to do a version bump of the package at the same time? |
Good call! |
0xmichalis
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from:
https://docs.toucan.earth/developers/sdk/subgraph.
This PR (original under #112) was kindly opened by @dankelleher. I just removed the API keys as we've decided to not expose them and get everybody to use their own.